Increase benchmark load from 500 to 30,000 requests - #4
Merged
Conversation
- Increased benchmark from 500 to 30,000 requests to take approximately 1 minute - Updated warmup count proportionally from 50 to 500 - Updated description to show expected runtime https://claude.ai/code/session_01EvvRtCaKeJje5SG1MjYWzK
- Fixed gRPC method lookup from "CreateOrderOrders" to "CreateOrder" (the actual generated method name) - Added benchmark results from 30,000 run test showing ~4.5× speedup for gRPC over HTTP with persistent connections Results: - Small payload: gRPC 1.18ms vs HTTP 5.38ms (4.57× faster) - Large payload: gRPC 1.37ms vs HTTP 6.12ms (4.46× faster) https://claude.ai/code/session_01EvvRtCaKeJje5SG1MjYWzK
Updated performance benchmarks with actual measurements from recent 30,000 request benchmark run: - Small payload: 5.38 ms (HTTP) vs 1.18 ms (gRPC), 4.6× speedup - Large payload: 6.12 ms (HTTP) vs 1.37 ms (gRPC), 4.5× speedup https://claude.ai/code/session_01EvvRtCaKeJje5SG1MjYWzK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the benchmark suite to use a significantly larger request volume (30,000 requests instead of 500) to provide more reliable and representative performance metrics.
Key Changes
bench_client.pybenchmarks/results/persistent_results.jsonwith results from the larger benchmark runDetails
This change improves the statistical significance of benchmark results by testing with a much larger sample size. The increased load provides better insight into performance characteristics and reduces variance in measurements, making the benchmarks more reliable for performance comparisons and regression detection.
https://claude.ai/code/session_01EvvRtCaKeJje5SG1MjYWzK