fix(cli): keep exit farewell out of non-interactive output - #110
Merged
Conversation
Contributor
|
The farewell on lines 84 and 85 runs before the cleanup in Also, would be good to have tests confirming that |
Owner
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
main.goprintedThanks for using Pgxcli.andsee you next time.after every successful Cobra command. This appended human-facing lines to non-interactive output such as--helpand--version, making the output harder for scripts to consume.The farewell is now emitted only after the interactive application returns successfully from
internal/cli/root.go. Non-interactive commands remain clean, while normal REPL exits retain the existing message.Validation
go test ./...go build -o /tmp/pgxcli-farewell-final .--help: no farewell lines--version:pgxcli version 0.3.0, no farewell linesgit diff --check