Add Claude Code GitHub Workflow - #1
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This was referenced Jun 29, 2026
axisrow
added a commit
that referenced
this pull request
Jul 8, 2026
…ad-timeout (#101 P0) (#102) * fix(security): drop PASSWORD_SECRET from proxy env + add slowloris read-timeout Two P0 unauthenticated-security fixes from the #101 code review. #1 (entrypoint.sh): `runuser` (without --login) inherits the caller's whole environment, so an operator-supplied `-e PASSWORD_SECRET=...` landed in the proxy's /proc/<pid>/environ — readable by any TTYD_USER process and enough to forge session/CSRF tokens. `unset PASSWORD_SECRET` after writing the secret file and before launching the proxy makes the mode-400 file the only channel, as CLAUDE.md guarantees. #2 (app/ttydproxy): BaseHTTPRequestHandler had no read timeout, so a slow client (slowloris) pinned a ThreadingHTTPServer worker forever (the login rate-limiter only fires after the slow window). Add a config-driven REQUEST_TIMEOUT (default 30s, min 1) applied as the handler's `timeout` class attribute. Implemented in config.py + app.py (the handler subclass) rather than the stdlib-only server.py so the value stays env-configurable and validated. Closes #101 findings #1, #2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgvJhzd8gEhXVE4MVu18nn * test: assert handler timeout is wired to config value (review cleanup) Non-blocking review nitpick from the local review of #102: the timeout test only asserted `> 0`. Also assert `TTYDProxyHandler.timeout == config.REQUEST_TIMEOUT` so a regression that hard-codes or drops the config wiring is caught. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgvJhzd8gEhXVE4MVu18nn --------- Co-authored-by: axisrow <axisrow@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Installing Claude Code GitHub App
This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository.
What is Claude Code?
Claude Code is an AI coding agent that can help with:
How it works
Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment.
Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action.
Important Notes
Security
There's more information in the Claude Code action repo.
After merging this PR, let's try mentioning @claude in a comment on any PR to get started!