fix: align log metadata with other SDKs#465
Open
zhongkechen wants to merge 1 commit into
Open
Conversation
e4afcde to
b286f5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fixes #440
Description
Align durable execution log metadata with the JavaScript and Python SDKs by moving MDC context management into
DurableLoggerand updating the emitted key names. This also separates logger scope cleanup from durable context objects so context lifecycles are clearer and less error-prone.DurableLoggerto manage MDC state through attach/detach helpers instead of storing a logger per durable context.SafeCloseableso logger context scopes can be used with try-with-resources without checked-exception noise.executionArninstead ofdurableExecutionArnoperationId/operationNameoperationId,operationName, andattemptLoggerConfig.oldKeyNamesto preserve backward compatibility for consumers that still expect the previous MDC field names.AutoCloseable/close()responsibilities from durable context types and make logger scoping explicit at user-code execution boundaries.DurableExecutor,StepOperation,ChildContextOperation, andWaitForConditionOperationto attach/detach logger scope around user code.ExecutionManagerandParallelDurableFutureto useSafeCloseableinstead ofAutoCloseable.Demo/Screenshots
Checklist
Testing
Added a new case
testLoggingExampleto runlogginer-example.Expanded
DurableLoggerTestcoverage for:Unit Tests
Yes
Integration Tests
No
Examples
N/A