feat(capacity-provider): restore Journey 1 - #2114
Open
aidandaly24 wants to merge 5 commits into
Open
Conversation
aidandaly24
temporarily deployed
to
e2e-testing
August 26, 2026 18:36 — with
GitHub Actions
Inactive
Contributor
Package TarballHow to installgh release download pr-2114-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.0.tgz |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
I verified this PR is exactly what it claims: a clean revert-of-revert restoring PR #2030 after the temporary revert in #2045.
Verification performed:
- Checked out
origin/mainand rangit revert 0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9. Git applied it automatically with no conflicts. - Diffed the result against the PR head (
git diff pr-2114) → empty output. The 44 files and 2,240/42 line stats match the inverse of the revert byte-for-byte. - Confirmed the intervening
feat(payments): Quick Create connector flowchanges (#2017) tosrc/cli/commands/status/action.tsare preserved — bothgetPaymentConnector/paymentConnectorsand the newly re-addedcapacityProvidersdiff logic coexist in the final file. - The CLI side of capacity provider is loosely coupled to the L3 construct: schema JSON writes on
add/remove, andparseCapacityProviderOutputsjust reads CFN outputs by name pattern — so this can land independently of the companion CDK PR without runtime issues (deploy just won't populate capacity provider outputs until the L3 lands). - Telemetry restoration is included (
command-run.ts,common-shapes.ts).
No new code changes are being introduced beyond the previously-reviewed #2030 content, so I have nothing new to flag. Safe to merge.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores capacity provider Journey 1 after #2045.
This is the exact inverse of revert commit
0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9, applied to currentmain. It restores the capacity provider schema, CLI and TUI add/remove flows, deploy/status/output handling, telemetry, documentation, and tests from #2030.Companion CDK PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/340
Related Issue
Restores #2030 after #2045.
Documentation PR
N/A. User-facing documentation is restored in this PR.
Type of Change
Testing
npm run test:unit(431 files, 6,193 tests passed)npm run test:integ(35 files, 350 tests passed, 1 skipped)npm run test:update-snapshots(6,193 tests passed, no snapshot drift)npm run typechecknpm run lintnpm run format:checknpm run buildnpm run test:tuireproduced the exact current-mainresult: 15 passed and 19 pre-existing failures, with no capacity-provider failuresVerified the complete branch diff is byte-for-byte equivalent to the inverse of
0cd32ba1f9d8a52f4309c1418baafa1b2b4ee0d9I ran
npm run test:unitandnpm run test:integI ran
npm run typecheckI ran
npm run lintIf I modified
src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.