feat(apigateway): access parent api resolver from router - #842
Merged
Conversation
added 6 commits
November 19, 2021 15:13
…r ApiGatewayResolver
# Conflicts: # tests/functional/event_handler/test_api_gateway.py
Codecov Report
@@ Coverage Diff @@
## develop #842 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 118 118
Lines 5108 5110 +2
Branches 280 280
========================================
+ Hits 5103 5105 +2
Misses 2 2
Partials 3 3
Continue to review full report at Codecov.
|
Contributor
|
Should we add a note in the docs? E.g. subclassing ApiGatewayResolver etc
…On Mon, 22 Nov 2021 at 09:15, Tom McCarthy ***@***.***> wrote:
@cakepietoast <https://github.com/cakepietoast> requested your review on:
#842 <#842>
feat: access api resolver from router.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#842 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBHAFHTNET5HSCMRX4DUNH327ANCNFSM5IQKXQYA>
.
|
Contributor
Author
I think if we add documentation here it needs to be a more widely scoped section explaining how and why you might want to subclass |
Contributor
|
Agree - that’s what I meant by whether it should be in the docs (explained
with an example).
LGTM
…On Wed, 24 Nov 2021 at 10:20, Tom McCarthy ***@***.***> wrote:
Should we add a note in the docs? E.g. subclassing ApiGatewayResolver etc
I think if we add documentation here it needs to be a more widely scoped
section explaining how and why you might want to subclass
ApiGatewayResolver, as opposed to just the particular detail this PR
implements. I'd like to try and understand how common this is, and what
some of the use cases are, before expanding on the docs there.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#842 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBATJ3NKP5P6QWNBJB3UNSU7BANCNFSM5IQKXQYA>
.
|
heitorlessa
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #834
Description of changes:
Enable access to parent api resolver class from child router classes. Example:
app.py
users.py
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.