Rename metrics and add service_name#73
Merged
Merged
Conversation
emschwartz
commented
Jul 10, 2023
emschwartz
commented
Contributor
- Update recording and alerting rules
- Add service_name to dashboards
- Make count suffix optional for Grafana queries
- Update histogram metric name
- Fix quotes in dashboard JSON
This was referenced Jul 10, 2023
brettimus
reviewed
Jul 17, 2023
| "options": { | ||
| "legend": { | ||
| "calcs": ["lastNotNull", "max"], | ||
| "calcs": [ |
Member
There was a problem hiding this comment.
sorry, when i merged in main i had to edit this file, and i forgot my vscode does "format on save" — so it reformatted a lot of trivial shtuff like this
brettimus
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.