github:toggle-git-tab-focus not focusing git tab

[ferranpm]

Prerequisites

• Have you tried to reproduce the problem in Safe Mode?
• Have you followed all applicable steps in the debugging guide?
• Have you checked the FAQs on the message board for common solutions?
• Have you checked that your issue isn't already filed?

Description

Invoking github:toggle-git-tab-focus both with ctrl-9 and via the command palette opens the git tab but does not focus the git tab.

Steps to Reproduce

1. Open a git project
2. Invoke github:toggle-git-tab-focus
3. While tab shows (if it's hidden) focus never leaves the editor.

Expected behavior: Files in git tab focused to stage/unstage them

Actual behavior: Focus did not change at all

Reproduces how often: Always

Versions

> atom --version    
Atom    : 1.28.0
Electron: 2.0.3
Chrome  : 61.0.3163.100
Node    : 8.9.3

> atom-beta --version
Atom    : 1.29.0-beta0
Electron: 2.0.3
Chrome  : 61.0.3163.100
Node    : 8.9.3

Additional Information

• Using the key binding resolver seems like ctrl-9 invokes github:toggle-git-tab-focus.
• github:toggle-github-tab-focus seems to work just fine

[lee-dohm]

I can confirm the described behavior using Atom v1.30.0-dev-f99077c68 on Mac OS X 10.13.5. Additionally:

1. When executing github:toggle-github-tab-focus with the focus on the editor, the focus leaves the editor but does not appear to arrive in the GitHub tab
2. When executing github:toggle-github-tab-focus with the focus in the GitHub tab, the focus does not leave the GitHub tab
3. When executing github:toggle-git-tab-focus when the focus is in the Git tab, the focus does leave the Git tab and properly arrive in the editor

[lee-dohm]

Something else I just noticed:

1. Launch Atom
2. Open the Git tab with github:toggle-git-tab, if it isn't already open
3. Open the GitHub tab with github:toggle-github-tab, if it isn't already open
4. With the GitHub tab focused, execute github:toggle-github-tab

Expected: The GitHub tab to disappear but the Git tab to remain and the right dock to remain open
Actual: The entire right dock closes

The same behavior is replicable when using the above process but swapping the Git tab and command for the GitHub tab and command.