This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add support for rename refactors - #270
Merged
Merged
Conversation
Contributor
|
Works for me on the last |
Contributor
Author
I have no idea, but if it does, I don’t know about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements rename refactoring support via
textDocument/rename, resolving #13. It is compatible with the protocol expected by the most recent release ofatom-ide-ui, which is0.13.0. Here’s a demonstration using theide-haskell-hiebackend:(It’s not the fastest backend in the world, but it gets the job done eventually.)
Awkwardly, this implementation doesn’t work with the latest version of
atom-ide-uiin the archived source code, since it was changed just after the final release to use a slightly different protocol. I don’t think that’s a big deal, though, since it’s always possible to bump the service version if those changes ever make it into something released.