Skip to content

fix(ci): remove persist-credentials false to allow semantic-release to push - #134

Merged
athal7 merged 1 commit into
mainfrom
fix-ci
Jul 28, 2026
Merged

fix(ci): remove persist-credentials false to allow semantic-release to push#134
athal7 merged 1 commit into
mainfrom
fix-ci

Conversation

@athal7

@athal7 athal7 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Problem

The release job in ci.yml had persist-credentials: false on the checkout step, which prevented semantic-release from:

  1. Pushing the version bump commit (via @semantic-release/git)
  2. Creating the GitHub release (via @semantic-release/github)

Fix

Removed persist-credentials: false so the GITHUB_TOKEN is available for git push and API operations.

Changes

  • .github/workflows/ci.yml: Removed persist-credentials: false from release job checkout

Summary by CodeRabbit

  • Chores
    • Updated release workflow checkout configuration.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 025e344b-8cc8-4a90-b3c0-2d836aa8f0ef

📥 Commits

Reviewing files that changed from the base of the PR and between d1c926e and 1fb8b43.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The release job’s checkout step removes persist-credentials: false and retains fetch-depth: 0.

Changes

Release workflow

Layer / File(s) Summary
Update release checkout
.github/workflows/ci.yml
The release job’s actions/checkout@v4 step now specifies only fetch-depth: 0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the CI change and its purpose for semantic-release pushes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci

Comment @coderabbitai help to get the list of available commands.

@athal7
athal7 merged commit 1fc832c into main Jul 28, 2026
38 of 43 checks passed
@athal7
athal7 deleted the fix-ci branch July 28, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant