Adopt the array api#885
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage ? 96.56%
=======================================
Files ? 8
Lines ? 1571
Branches ? 0
=======================================
Hits ? 1517
Misses ? 54
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
85625f0 to
04293b7
Compare
|
As a quick FYI I ran the test suite in this PR on a machine with a NVidia GPU with |
| readme = "README.rst" | ||
| license = { text = "BSD-3-Clause" } | ||
| requires-python = ">=3.8" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
Adopt Spec 0? Has that been adopted?
There was a problem hiding this comment.
Wait, misread this -- what is Spectrum 0?
There was a problem hiding this comment.
There was a problem hiding this comment.
So the move here would be to bump it up to 3.12?
There was a problem hiding this comment.
3.11 for a few more months. Then 3.12. I was also thinking about adding the badge saying "Spec 0", e.g. you can see in the README in https://github.com/GalacticDynamics/unxt
| readme = "README.rst" | ||
| license = { text = "BSD-3-Clause" } | ||
| requires-python = ">=3.8" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
2fa76b7 to
3b2b9fc
Compare
These are necessary because upstream dependencies (astropy) explicitly check for numpy arrays rather than using the array API.
new_data never has a .data the way the test is written
5c81f63 to
2a877a9
Compare
91b1118 to
e2a808f
Compare
|
🎉 |
This PR makes the necessary changes to adopt the array API. There are still some things to sort out:
.data_arr.maskto.data_arr_maskconstitutes an API change. If it does (and I think it does) then patch things up so that.data_arr.maskpoints to.data_arr_maskarray_api_extramakes handling those easy)Once those are done the next step will be to find an outside reviewer for this...