Skip to content

Preserve size of mask when all values are False in HeasarcClass.locate_data#3411

Merged
bsipocz merged 2 commits into
astropy:mainfrom
matteobachetti:patch-1
Sep 17, 2025
Merged

Preserve size of mask when all values are False in HeasarcClass.locate_data#3411
bsipocz merged 2 commits into
astropy:mainfrom
matteobachetti:patch-1

Conversation

@matteobachetti

Copy link
Copy Markdown
Contributor

Resolve #3410

@codecov

codecov Bot commented Sep 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.51%. Comparing base (e48e283) to head (ea9abd4).
⚠️ Report is 221 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3411   +/-   ##
=======================================
  Coverage   70.50%   70.51%           
=======================================
  Files         232      232           
  Lines       19999    19997    -2     
=======================================
- Hits        14101    14100    -1     
+ Misses       5898     5897    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the v0.4.11 milestone Sep 16, 2025
@bsipocz bsipocz added the bug label Sep 16, 2025
@bsipocz

bsipocz commented Sep 17, 2025

Copy link
Copy Markdown
Member

cc @zoghbi-a

@zoghbi-a
zoghbi-a self-requested a review September 17, 2025 13:41

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bsipocz
bsipocz merged commit 4623c1f into astropy:main Sep 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HeasarcClass.load_data failing with Illegal type <class 'numpy.bool'> for table item access

3 participants