Update heasarc.rst#3390
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
+ Coverage 70.18% 70.27% +0.09%
==========================================
Files 232 232
Lines 19937 19970 +33
==========================================
+ Hits 13992 14034 +42
+ Misses 5945 5936 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please squash and merge. Only the last two commits are relevant. Let me know if you'd prefer a cleaned-up branch. |
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Please remove the changelog entry and squash all commits together (indeed as you mentioned a clean commit history is preferred and we don't have squash merges.)
| - Heasarc.locate_data returns empty rows with an error in the error_message column if there are | ||
| no data associated with that row rather than filtering it out. [#3275] | ||
| - Heasarc.locate_data changed to use POST request instead of GET to accomodate large requests. [#3356] | ||
| - maxrec in Heasarc.query_region maxes out on 1e5 regardless of how it is set. Use instead an ADQL query using the TOP parameter set to something larger than 1e5. [#3390] |
There was a problem hiding this comment.
no need for the changelog for docs and non user facing code changes, please remove
| though you may find that maxrec has a hard limit of 1e5 regardless of how you set it. See `issue #3387 tracker <https://github.com/astropy/astroquery/issues/3387>`_. | ||
|
|
There was a problem hiding this comment.
no need to add xref to astroquery issue. once that one is fixed the docs can be updated.
7296f5f to
ca07e4b
Compare
|
Changelog entry removed. xref in heasarc.rst updates removed. Squashed all commits into one. |
…ropy#3387 Update CHANGES.rst -- removed changelog entry (not needed) Update heasarc.rst -- removed xref (not needed)
|
Thank you! |
2 participants
Adding relevant information regarding issue #3387