Download Products with MastMissions#3155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 67.57% 67.75% +0.17%
==========================================
Files 229 229
Lines 18593 18733 +140
==========================================
+ Hits 12565 12692 +127
- Misses 6028 6041 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tagging @astrojimig and @dr-rodriguez for visibility |
|
Pinging this MR again just in case it got lost in the shuffle of the holidays and/or AAS. |
ac7f334 to
aab812a
Compare
bsipocz
left a comment
There was a problem hiding this comment.
Thanks. Overall this looks good.
I noticed there are a couple of test failures and errors, but all of the look unrelated to this PR, so I go ahead with the merge now. If you could look into them and open a PR with a fix, it would be great.
| # Return filtered products | ||
| return products[filter_mask] | ||
|
|
||
| def download_file(self, uri, *, local_path=None, cache=True, verbose=True): |
There was a problem hiding this comment.
we'll need to unify all these download fuctionalities between the different modules. So it's more like a heads up, that something will come in place as a utility either in astroquery or in pyvo
There was a problem hiding this comment.
Thank you for the heads up! I put the test fixes into #3164.
|
Thanks! |
|
Was this supposed to be in the newest release? The release was made after this was merged, but it doesn't seem like this merge is in the included commits. |
|
It should be in it but I may have messed up the cherry picking. (It was a one off quick release to fix some regression, so not everything got included) |
Download Products with MastMissions
|
I ended up doing a 0.4.9.post1 release as I used the same errenous cherry-pick command for multiple PRs. A normal |
This MR adds methods to
MastMissionsthat allow users to retrieve and download products from the Missions-MAST API.get_product_listget_unique_product_listfilter_productsdownload_productsdownload_fileA few notes:
missionproperty so that users can use the sameMastMissionsobject to query multiple missions.dataset_kwdsand_default_ullyses_cols, for example). These are due to limitations in the API, and I've reported these problems internally at MAST.missions_request_asyncfunction toservices.pyto handle API requests coming fromMastMissions.