INFO message when removing duplicate products should give the correct number of products based on filters#3074
Merged
Conversation
snbianco
marked this pull request as ready for review
July 24, 2024 19:43
bsipocz
reviewed
Jul 24, 2024
bsipocz
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2496 and #2497
Quick fix so that the number of products given in the INFO message in
_remove_duplicate_productsreflects any filters that were applied to the products. I did this by switching the order of the calls indownload_productsso that filters are applied to the product list before duplicates are removed.