Recognize slice and frozendict generics - #28477
Merged
Merged
Conversation
Summary -- This PR updates our standard library generic recognition to include `frozendict` and `slice`. `F401` is just an example of an affected rule because we visit the subscript arguments of known stdlib generics as type expressions: https://github.com/astral-sh/ruff/blob/275e6112e4c5d383179efaa424c8d774acf9fe58/crates/ruff_linter/src/checkers/ast/mod.rs#L2177-L2181 Test Plan -- mdtests including `F401` to exercise the new behavior
AlexWaygood
approved these changes
Sep 9, 2026
|
|
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ntBre
marked this pull request as ready for review
September 9, 2026 22:00
ntBre
enabled auto-merge (squash)
September 9, 2026 22:01
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our standard library generic recognition to include
frozendictandslice.F401is just an example of an affected rule because we visit the subscript arguments of known stdlib
generics as type expressions:
ruff/crates/ruff_linter/src/checkers/ast/mod.rs
Lines 2177 to 2181 in 275e611
Test Plan
mdtests including
F401to exercise the new behavior