Skip to content

Reuse parser name lookups when interning - #28399

Merged
charliermarsh merged 2 commits into
mainfrom
charlie/parser-single-lookup-interner
Sep 7, 2026
Merged

charliermarsh merged 2 commits into
mainfrom
charlie/parser-single-lookup-interner

Conversation

@charliermarsh

Copy link
Copy Markdown
Member

Use hashbrown's borrowed-entry insertion for long parser names so a missing name reuses its lookup when it is inserted. Construct the heap-backed Name only on a miss, while preserving the inline bypass and shared allocations for repeated long names.

@astral-sh-bot

astral-sh-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 97.84%. The percentage of expected errors that received a diagnostic held steady at 96.45%. The number of fully passing files held steady at 128/145.

@astral-sh-bot

astral-sh-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

Memory usage report

Memory usage unchanged ✅

@astral-sh-bot

astral-sh-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff (timing results)

@astral-sh-bot

astral-sh-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh
charliermarsh marked this pull request as ready for review September 7, 2026 21:40
@charliermarsh charliermarsh added the performance Potential performance improvement label Sep 7, 2026
@charliermarsh
charliermarsh merged commit e7adf82 into main Sep 7, 2026
69 checks passed
@charliermarsh
charliermarsh deleted the charlie/parser-single-lookup-interner branch September 7, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant