[ty] Compare bound-method receivers before signatures - #28384
Draft
charliermarsh wants to merge 1 commit into
Draft
[ty] Compare bound-method receivers before signatures#28384charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.84%. The percentage of expected errors that received a diagnostic held steady at 96.45%. The number of fully passing files held steady at 128/145. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
trio
sphinx
prefect
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound methods with incompatible captured receivers currently compare their function signatures first, which can expand recursive
Selfbounds unnecessarily. We now check the captured receivers first and reject the relation immediately when that comparison produces an unconditional failure.Function evidence still precedes receiver evidence in the resulting constraints. Diagnostic collection retains the original evaluation order so signature mismatches keep their existing error context.
Against
e579b84aba, the existing Pydantic CodSpeed walltime benchmark measured 2.704 s before and 2.615 s after this change alone. This is a 3.3% reduction in elapsed time in this sample. These local measurements use one process pair with six samples per process and two iterations per sample.