[ty] Compare signature parameters before return types - #28383
Draft
charliermarsh wants to merge 1 commit into
Draft
[ty] Compare signature parameters before return types#28383charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 97.84%. The percentage of expected errors that received a diagnostic held steady at 96.45%. The number of fully passing files held steady at 128/145. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
sphinx
trio
prefect
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
0 | 0 | 2 |
invalid-return-type |
0 | 0 | 2 |
| Total | 0 | 0 | 4 |
Raw diff:
Expression (https://github.com/cognitedata/Expression)
- docs/guides/pipelines.py:50:21 error[invalid-argument-type] Argument is incorrect: Expected `Unknown & _A'return@curry_flip`, found `list[dict[str, str | bool]]`
+ docs/guides/pipelines.py:50:21 error[invalid-argument-type] Argument is incorrect: Expected `_A'return@curry_flip & Unknown`, found `list[dict[str, str | bool]]`
- docs/tutorial/introduction.py:58:21 error[invalid-argument-type] Argument is incorrect: Expected `Unknown & _A'return@curry_flip`, found `list[dict[str, str | int]]`
+ docs/tutorial/introduction.py:58:21 error[invalid-argument-type] Argument is incorrect: Expected `_A'return@curry_flip & Unknown`, found `list[dict[str, str | int]]`
static-frame (https://github.com/static-frame/static-frame)
- static_frame/core/index.py:1297:16 error[invalid-return-type] Return type does not match returned value: expected `Iterator[Hashable | complex | integer[Any] | ... omitted 8 union elements]`, found `reversed[ndarray[tuple[Any, ...], Any] | Any]`
+ static_frame/core/index.py:1297:16 error[invalid-return-type] Return type does not match returned value: expected `Iterator[Hashable | complex | integer[Any] | ... omitted 8 union elements]`, found `reversed[Any | ndarray[tuple[Any, ...], Any]]`
- static_frame/core/series_mapping.py:60:16 error[invalid-return-type] Return type does not match returned value: expected `Iterator[TVValues@SeriesMappingValuesView]`, found `reversed[ndarray[tuple[Any, ...], Any] | Any]`
+ static_frame/core/series_mapping.py:60:16 error[invalid-return-type] Return type does not match returned value: expected `Iterator[TVValues@SeriesMappingValuesView]`, found `reversed[Any | ndarray[tuple[Any, ...], Any]]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signature comparisons currently explore return types even when incompatible parameters already rule out a match. For standard parameter lists, we now compare parameters first and skip the return comparison when their constraints cannot be satisfied. This avoids expanding large recursive return types for overloads that cannot match.
We still combine return-type evidence before parameter evidence when selecting constraint solutions. Diagnostic collection and
ParamSpecsignatures retain the original evaluation order, including binding behavior for incompatible returns.Against
e579b84aba, the existing Pydantic CodSpeed walltime benchmark measured 2.722 s before and 2.628 s after this change alone. This is a 3.5% reduction in elapsed time in this sample. These local measurements use one process pair with six samples per process and two iterations per sample.