Speed up inherited configuration resolution - #28299
Merged
charliermarsh merged 2 commits intoSep 4, 2026
Merged
charliermarsh merged 2 commits into
charliermarsh merged 2 commits into
Conversation
## Summary Projects that extend the same Ruff configuration repeatedly parse its options and compile inherited per-file globs during file discovery. Reuse that work within each traversal to reduce configuration overhead when checking many projects. Cache parsed and normalized configurations by file path and normalization root, before inheritance merging and CLI overrides. Share per-file glob compilation across configuration clones, preserving the existing post-override compilation order and matching behavior. Reuse path candidates during matching and skip empty per-file target-version lookups. The cache lasts for one traversal; later traversals reload configurations. Parsing stays outside the cache lock so unrelated files can load in parallel. Concurrent misses can load the same file more than once. ## Test Plan Existing CLI and workspace regressions pass for inherited configuration errors, relative paths, CLI overrides, negated per-file ignores, and target versions for linting and formatting. No snapshots changed.
charliermarsh
approved these changes
Sep 4, 2026
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Projects that extend the same Ruff configuration repeatedly parse its
options and compile inherited per-file globs during file discovery.
Reuse that work within each traversal to reduce configuration overhead
when checking many projects.
Cache parsed and normalized configurations by file path and
normalization root, before inheritance merging and CLI overrides. Share
per-file glob compilation across configuration clones, preserving the
existing post-override compilation order and matching behavior. Reuse
path candidates during matching and skip empty per-file target-version
lookups.
The cache lasts for one traversal; later traversals reload
configurations. Parsing stays outside the cache lock so unrelated files
can load in parallel. Concurrent misses can load the same file more than
once.
Test Plan
Existing CLI and workspace regressions pass for inherited configuration
errors, relative paths, CLI overrides, negated per-file ignores, and
target versions for linting and formatting. No snapshots changed.