[flake8-implicit-str-concat] Mark fix unsafe when it creates a docstring (ISC003) - #27981
Merged
Merged
Conversation
ntBre
reviewed
Aug 28, 2026
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks reasonable overall. I just had a few comments on the tests and a couple of suggestions on simplifying the implementation.
Removing '+' from the first statement of a module, function, or class body turns the concatenation into a docstring, changing __doc__ and program behavior. Detect docstring positions and emit the fix with unsafe applicability instead. Closes astral-sh#27979
Contributor
Author
|
Thanks for the review, @ntBre! All suggestions addressed:
Verified locally: |
mdiniz97
force-pushed
the
fix/isc003-docstring-safety
branch
from
August 28, 2026 21:38
930b1d8 to
ab72382
Compare
flake8-implicit-str-concat] Mark fix unsafe when it creates a docstring (ISC003)
ntBre
approved these changes
Sep 3, 2026
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
I pushed a small commit trimming down some comments, removing an extra newline, and adding fix safety docs, but this looked good to me.
ntBre
enabled auto-merge (squash)
September 3, 2026 19:00
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27979
Removing the
+from the first statement of a module, function, or class body turns the concatenation into a docstring, changing__doc__and program behavior. Detect docstring positions and emit the fix with unsafe safety level instead.Test Plan
cargo test -p ruff_linter --lib(2813 pass), clippy + fmt clean