[ruff] Remove lint.external hint for Ruff-specific suppressions (RUF102) - #27923
Merged
Merged
Conversation
Remove the "Add non-Ruff rule codes to the `lint.external` configuration option" help message from the suppression path (RUF102/RUF104). The `# ruff: ignore` directive is a Ruff-specific suppression mechanism and should not suggest adding codes to `lint.external`. The noqa path (RUF102) still handles this tip for `# noqa` directives, which is the appropriate context for external rule codes. Closes astral-sh#27880.
|
ntBre
changed the title
ruff] Remove lint.external hint for Ruff-specific suppressions (RUF102)
ntBre
approved these changes
Aug 28, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
It turned out that we actually discussed this hint a bit in #25614 (comment), but I'm not sure why I ended up preserving it. This change makes sense to me now.
ntBre
added
bug
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the "Add non-Ruff rule codes to the
lint.externalconfiguration option" help message from the suppression path (RUF102/RUF104).The
# ruff: ignoredirective is a Ruff-specific suppression mechanism. When a user writes an unknown code in a# ruff: ignoredirective, it is typically a typo or a rule name with preview disabled — not a non-Ruff rule code. The help message suggesting to add the code tolint.externalis therefore misleading in this context.The noqa path (RUF102) still handles this tip for
# noqadirectives, which is the appropriate context for external rule codes.Closes #27880.
Changes
has_unknown_codefield fromSuppressionDiagnosticand the help message that was emitted when it was set.