[flake8-pytest-style] Avoid duplicate PT017 diagnostics - #27918
Merged
Merged
Conversation
|
ntBre
approved these changes
Aug 31, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thank you! This looks good to me, I just had a minor simplification suggestion to avoid the new flag.
And thanks @Pierre-Sassoulas for the review/ping!
| }, | ||
| current_assert.range(), | ||
| ); | ||
| self.diagnostic_reported = true; |
Contributor
There was a problem hiding this comment.
Instead of adding a new flag, could we just reset self.current_assert to None here? Maybe with a rename to pending_assert or at least a docstring for the field to explain the usage.
ntBre
changed the title
flake8-pytest-style] Avoid duplicate PT017 diagnostics
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27870