[flake8-pyi] Fix false positive in __all__ (PYI053)#26872
Open
ntBre wants to merge 3 commits into
Open
Conversation
Summary -- This PR fixes a false positive on long strings in `__all__`. These strings correspond to existing exported symbols and are out of the stub author's control. I initially hoped that we could use the existing `Semantic::in_dunder_all_definition`, but this is only set in `Checker::visit_exports` and used for adding global references, so the flag is no longer set when the rule runs in `Checker::visit_expr`. I found another similar piece of existing code in `Checker::handle_node_store` and factored that out into a `Checker` helper method. Test Plan -- New mdtest
ntBre
added
bug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a false positive on long strings in
__all__. These strings correspond to existingexported symbols and are out of the stub author's control.
I initially hoped that we could use the existing
Semantic::in_dunder_all_definition, but this isonly set in
Checker::visit_exportsand used for adding global references, so the flag is no longerset when the rule runs in
Checker::visit_expr.I found another similar piece of existing code in
Checker::handle_node_storeand factored that outinto a
Checkerhelper method.Test Plan
New mdtest