Add markdown to types_or - #159
Open
34j wants to merge 1 commit into
Open
Conversation
Member
|
Thank you. I think we should wait until the feature is out of preview before changing our defaults. |
Contributor
|
Could you update the |
Contributor
|
It came out of preview! https://astral.sh/blog/ruff-v0.16.0 |
ntBre
reviewed
Jul 24, 2026
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks straightforward to me, I just suggested dropping markdown from the linter invocation. Could you also add it to the README as suggested by the comments?
Happy to handle it if you'd prefer, I know it has been a long time :)
| entry: ruff check --force-exclude | ||
| language: python | ||
| types_or: [python, pyi, jupyter] | ||
| types_or: [python, pyi, jupyter, markdown] |
Contributor
There was a problem hiding this comment.
I think I'd just exclude this line for now. It shouldn't really hurt anything, but ruff check still doesn't perform any checks on Markdown files, only ruff format.
Suggested change
| types_or: [python, pyi, jupyter, markdown] | |
| types_or: [python, pyi, jupyter] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now
*.mdfiles are intool.ruff.includeby default and may be used withtool.ruff.format.preview = True, etc.https://docs.astral.sh/ruff/settings/#include
astral-sh/ruff@4795eca#diff-959aaaf28345388cb476e91b1a8b127625bffba0ca2f8ed794f687bd27e50302
Test Plan