Temporarily disable the SslStream benchmark runs#2139
Merged
LoopedBard3 merged 1 commit intoJan 12, 2026
Conversation
Member
|
But this file is generated. Isn't there a property on the steps to just ignore them? Or comment the job in the inner yaml (which I have done many times already) |
…seem to be exiting properly, causing follow-up test runs to timeout.
LoopedBard3
force-pushed
the
TemporarilyDisableSSLStreamBenchmarks
branch
from
11f8517 to
0143a37
Compare
Contributor
Author
|
Just pushed an updated, let me know if that is more in-line with the approach you mentioned. |
sebastienros
approved these changes
Jan 12, 2026
LoopedBard3
added a commit
to LoopedBard3/Benchmarks
that referenced
this pull request
May 18, 2026
…rios Root cause (issue aspnet#2140 / disabled in aspnet#2139): Crank's Linux agent stops jobs with SIGTERM first (5 s grace) then SIGINT. BenchmarkApp only handled Console.CancelKeyPress (SIGINT), so SIGTERM bypassed the graceful cancellation path. In-flight TLS/QUIC connections never observed cancellation and could leave the listen port stranded for the next run -- which is what 'app does not seem to be exiting properly' in aspnet#2139 actually described. Fix is three layered: 1. BenchmarkApp now registers PosixSignalRegistration for SIGTERM and SIGQUIT in addition to Console.CancelKeyPress, so GlobalCts.Cancel runs on every shutdown signal crank can send. PosixSignalRegistration is no-op-friendly on Windows so the existing Ctrl+C path is unchanged. 2. BenchmarkApp wraps RunBenchmarkAsync with a 15 s hard shutdown deadline after cancellation. If disposal stalls (stuck SslStream close_notify, QuicConnection drain, etc.) Environment.Exit guarantees we release the port before crank's SIGKILL fallback fires. 3. BenchmarkServer now tracks per-accepted-connection Task.Run handles and drains them with a 10 s timeout before letting the listener dispose, so SslStream/Quic disposal doesn't race the listener teardown. Re-enable in build/sslstream-scenarios.yml: remove the '&& false' gate from all four scenario matrices (SslStream handshake, QUIC handshake, SslStream read-write, QUIC read-write). 66 publishes added back, on alternate 12 h ticks via the existing Math.round(Date.now() / 43200000) % 2 == 0 modulo (preserved on all four). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily disable the SslStream benchmark runs as the app does not seem to be exiting properly, causing follow-up test runs to timeout.