Skip to content

feat: trim branch from center#116

Merged
arl merged 2 commits into
arl:mainfrom
rtalexk:feat/trim-branch-from-center
Jun 9, 2024
Merged

feat: trim branch from center#116
arl merged 2 commits into
arl:mainfrom
rtalexk:feat/trim-branch-from-center

Conversation

@rtalexk

@rtalexk rtalexk commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Purpose

I tend to follow a naming convention for branches, and when I work on big features that are split into different PRs, the beginning and the end of the branches contains the most significant context, i.e: feat/<ticket_id>/<feature-name>-<feature-portion>. In these cases I find useful seeing the beginning of the branch, and as I already know which feature I'm working on, I find more value by seeing the last part, as it usually refers to a smaller portion of the whole feature.

Hopefully others also finds this useful.

Approach

Trim the branch from the inside out, so that

feat/COR-1032/supplier-billing-profile-invoice-upload

becomes

feat/COR-1032/…invoice-upload

@rtalexk
rtalexk force-pushed the feat/trim-branch-from-center branch from 551d1d8 to a882b42 Compare June 9, 2024 00:39

@arl arl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing that, very helpful.

Can you please update the documentation in .gitmux.yml at project root? This file gets embedded in the binary at build time and serves as default config for gitmux -printcfg?

Comment thread tmux/formater.go Outdated
Comment thread tmux/formater.go Outdated
Comment thread tmux/formater_test.go

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the complete test cases

@rtalexk
rtalexk force-pushed the feat/trim-branch-from-center branch 2 times, most recently from 02a8952 to cc84284 Compare June 9, 2024 02:35
@rtalexk
rtalexk force-pushed the feat/trim-branch-from-center branch from cc84284 to 45568dc Compare June 9, 2024 02:37

@arl arl left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arl
arl merged commit bb31d30 into arl:main Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants