Jira 857, BLEPeripheral::connected() always returns false, git 444 - #454
Merged
Conversation
Root casue: - The stack need use connected device to get the state. - The current code used local address to get the link and get an error. Code mods: 1. BLEPeripheral.cpp: - Use central's address to get connection state.
SidLeung
requested review from
bigdinotech,
eriknyquist,
noelpaz and
russmcinnis
February 23, 2017 18:50
Contributor
Author
|
This PR is originated from #447 @eriknyquist , since you have approved this segment of code change at #447, please mark this PR approved. @russmcinnis @noelpaz , no need re-test since you have tested this item using #447 for Jira 857. |
eriknyquist
approved these changes
Feb 23, 2017
Contributor
Author
|
@yashaswini-hanji , please merge to main trunk and close out Jira 857. |
Contributor
|
PR merged and closed Jira 857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root casue:
Code mods: