Conversation
| ); | ||
| } | ||
|
|
||
| // Preload the webfonts so text paints in the real face rather than swapping |
There was a problem hiding this comment.
Whoa that's a big find. Let's just remove the preloading to avoid the complexity here and open a ticket for another go at it later.
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
This is great. High level advice on the best approach to CLAUDE.md / AGENTS.md / ARCHITECTURE.md provided.
| # CLAUDE.md | ||
|
|
||
| Machine-readable project brief for AI coding assistants. Facts and conventions only. | ||
| This project's agent brief lives in [AGENTS.md](AGENTS.md). |
There was a problem hiding this comment.
Claude has new canonical guidance on the best way to do this:
|
|
||
| ## Templates: JSX | ||
|
|
||
| This project's templates are written in **JSX** rather than Nunjucks. JSX is a server-side |
There was a problem hiding this comment.
According to my research, CLAUDE.md will probably ignore ARCHITECTURE.md unless it is at least mentioned in AGENTS.md (which in turn should be fully @-imported by CLAUDE.md).
I'm a little skeptical that it would never be read (Claude is pretty inquisitive), but I think it makes sense to name-drop it and explain its role in AGENTS.md, as opposed to fully @-importing it there which would force it to be loaded all the time.
CLAUDE.md pointed at AGENTS.md with a markdown link, which Claude Code's @-import parser doesn't recognize — AGENTS.md was never actually loaded into context. Switch to a real @AGENTS.md import per the canonical guidance (https://code.claude.com/docs/en/memory#agents-md). Also have AGENTS.md name-drop ARCHITECTURE.md and explain its role, per PR review feedback, without @-importing it (it's long prose largely overlapping AGENTS.md's tables, not worth loading every session). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1R6qsqGA2kcR2zWN1PrTk
2 participants
Please indicate which branch this PR should merge into:
Check one
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR makes some improvements to the original
jsxbranch around translations plus code comments to reflect it will be the main, rather than JSX example branch. It also adds skills files. Takes steps toward closing PRO-9710.What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: