solve PRO-9899 by not using hash URLs in the first place, we already have release IDs in the URLs - #5624
Merged
Conversation
…have release IDs in the URLs
BoDonkey
approved these changes
Sep 25, 2026
BoDonkey
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked this thoroughly including a production build with APOS_UPLOADFS_ASSETS=1. There's no reason to have the hash in a font URL at all as long as we use the full path rather than trying to push them all into one folder. This solves the problem by mostly removing code rather than adding it. The original, "natural" solution of
apos.asset.urlworks correctly now (see separate public-demo PR).