Migrate node-fetch to built-in fetch (undici) - #5487
Merged
Merged
Conversation
boutell
requested changes
Jun 23, 2026
| "apostrophe": minor | ||
| --- | ||
|
|
||
| The server-side HTTP client (`apos.http`) now uses Node's built-in `fetch` instead of `node-fetch`. |
Member
There was a problem hiding this comment.
We need to provide a justification for why this is not a major version break. I think because node-fetch is no longer maintained?
Member
|
I am not in any way suggesting it SHOULD be a major version break. God no.
I'm just saying we should offer some explanation for why this change is
being made now in the way that it is as part of the changelog.
…On Tue, Jun 23, 2026 at 10:01 AM Miro Yovchev ***@***.***> wrote:
@myovchev <https://github.com/myovchev> requested your review on:
apostrophecms/apostrophe#5487
<#5487> Migrate
node-fetch to built-in fetch (undici).
—
Reply to this email directly, view it on GitHub
<#5487?email_source=notifications&email_token=AAAH27LNKLCTTJHUDISZWAL5BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-27097365928>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27JC5Z3E5DBGF4VWX3L5BKETTAVCNFSNUABDKJSXA33TNF2G64TZHM4DCMBQGM3TAO2JONZXKZJ3GQ3TENRVHEYDKOBWUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAAH27ILI2OXJXRURYR4BE35BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AAAH27JGHPUIUXR5P4L3QKD5BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because your review was requested.Message ID:
***@***.***>
--
THOMAS BOUTELL | CHIEF EXECUTIVE OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
|
Member
|
Also I'm not sure the backwards compatibility measures were mentioned.
…On Tue, Jun 23, 2026 at 11:51 AM Tom Boutell ***@***.***> wrote:
I am not in any way suggesting it SHOULD be a major version break. God no.
I'm just saying we should offer some explanation for why this change is
being made now in the way that it is as part of the changelog.
On Tue, Jun 23, 2026 at 10:01 AM Miro Yovchev ***@***.***>
wrote:
> @myovchev <https://github.com/myovchev> requested your review on:
> apostrophecms/apostrophe#5487
> <#5487> Migrate
> node-fetch to built-in fetch (undici).
>
> —
> Reply to this email directly, view it on GitHub
> <#5487?email_source=notifications&email_token=AAAH27LNKLCTTJHUDISZWAL5BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-27097365928>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAH27JC5Z3E5DBGF4VWX3L5BKETTAVCNFSNUABDKJSXA33TNF2G64TZHM4DCMBQGM3TAO2JONZXKZJ3GQ3TENRVHEYDKOBWUF3AE>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/AAAH27ILI2OXJXRURYR4BE35BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/AAAH27JGHPUIUXR5P4L3QKD5BKETTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZQHE3TGNRVHEZDRJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
--
THOMAS BOUTELL | CHIEF EXECUTIVE OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
--
THOMAS BOUTELL | CHIEF EXECUTIVE OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
|
Contributor
Author
|
Changelog now clarifies the reasons and BC state of things, should be much clear now. |
myovchev
commented
Jun 24, 2026
| self.setTotal(job, ids.length); | ||
| // Persist the total before work begins so the completed notification | ||
| // and job document always report it, even if processing finishes fast. | ||
| await self.setTotal(job, ids.length); |
Contributor
Author
There was a problem hiding this comment.
A bonus fix, unrelated to the ticket scope, but a real world problem revealed by randomly failing test.
boutell
approved these changes
Jun 24, 2026
myovchev
added a commit
that referenced
this pull request
Jun 24, 2026
* Migrate node-fetch to built-in fetch (undici), remove the node-fetch dep * Better changelog details, fix IPv6 test issues (CI) * Fix batch total race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please indicate which branch this PR should merge into:
Summary
Migrate node-fetch to built-in fetch (undici), remove the node-fetch dep. Full details in the changelog.
This is required due to the fact
node-fetchis a deprecated and not following node standards. A better long term contract.What are the specific steps to test this change?
No internal BC break.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: