Skip to content

fix: treat col as a self-closing tag #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BoDonkey merged 2 commits into from
Jun 16, 2026
+18 −1
Merged

fix: treat col as a self-closing tag #5447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e83a89
fix: treat col as a self-closing tag
vansh1011 Jun 7, 2026
0e50096
chore: add changeset for sanitize-html fix
vansh1011 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-hats-kneel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"apostrophe": patch
---

Fix invalid HTML output for <col> elements in sanitize-html (treat void elements correctly)
2 changes: 1 addition & 1 deletion packages/sanitize-html/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ sanitizeHtml.defaults = {
'alt'
],
// Lots of these won't come up by default because we don't allow them
selfClosing: [ 'img', 'br', 'hr', 'area', 'base', 'basefont', 'input', 'link', 'meta' ],
selfClosing: [ 'img', 'br', 'hr', 'area', 'base', 'basefont', 'input', 'link', 'meta', 'col' ],
// URL schemes we permit
allowedSchemes: [ 'http', 'https', 'ftp', 'mailto', 'tel' ],
allowedSchemesByTag: {},
Expand Down
12 changes: 12 additions & 0 deletions packages/sanitize-html/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ describe('sanitizeHtml', function() {
it('should pass through simple, well-formed markup', function() {
assert.equal(sanitizeHtml('<div><p>Hello <b>there</b></p></div>'), '<div><p>Hello <b>there</b></p></div>');
});
it('should preserve col as a self closing tag', function() {
assert.equal(
sanitizeHtml(
'<table><colgroup><col span="2"></colgroup></table>',
{
allowedTags: false,
allowedAttributes: false
}
),
'<table><colgroup><col span="2" /></colgroup></table>'
);
});
it('should not pass through any text outside html tag boundary since html tag is found and option is ON', function() {
assert.equal(sanitizeHtml('Text before html tag<html><div><p>Hello <b>there</b></p></div></html>Text after html tag!P�X��[<p>paragraph after closing html</p>', {
enforceHtmlBoundary: true
Expand Down