Skip to content

PRO-9542: fix the bug that breaks sitemaps for RA #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boutell merged 2 commits into from
May 26, 2026
Merged

PRO-9542: fix the bug that breaks sitemaps for RA #5433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b335239
PRO-9542: fix the bug that breaks sitemaps for RA
boutell May 25, 2026
113f180
see changeset
boutell May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sparkly-experts-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"apostrophe": patch
---

Sites with a custom filterByIndexPage method no longer experience failures in the sitemap module and potential creeping CPU performance penalties. A regression introduced with our static site support, but not specific to static sites.
7 changes: 7 additions & 0 deletions packages/apostrophe/modules/@apostrophecms/piece-page-type/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,14 @@ module.exports = {
return metadata;
}
const [ pm ] = metadata;
// indexQuery is designed to be called with the
// index page in question as req.data.page. To
// reuse it for URL metadata purposes we must
// meet that expectation
const pageWas = req.data.page;
req.data.page = doc;
const query = self.indexQuery(req);
req.data.page = pageWas;
const filters = await self.getFiltersWithChoices(query, { allCounts: true });

// 1. Enumerate every filter + choice combination
Expand Down
Loading