Fix admin UI crashes - #5195
Merged
Merged
Fix admin UI crashes#5195
Conversation
ETLaurent
approved these changes
Dec 4, 2025
haroun
added a commit
that referenced
this pull request
Dec 10, 2025
* main: (26 commits) more (#5207) adds permission.isAdmin (#5192) Skip string choices, disallow type change (#5203) Fix stylelint dependency conflict (#5199) oops old version number in main (#5201) just merging back the changelog (#5198) PRO-8758: soft-redirect and url encoding (#5191) Fix admin UI crashes (#5195) PRO-8756: monorepo workflows (#5179) PRO-8768: relative paths for the good operating systems (#5194) bump express-cache-on-demand to 1.0.4 (#5190) the video is no longer available, use apostrophecms channel video wit… (#5183) add changelog for pro-8751 (#5187) pro 8751 schema update (#5176) Pro 8761 i18n static tests (#5185) Pro 8756 monorepo switch (#5177) release 4.24.0 (#5173) PRO-8743: windows fix 2b: back off on the file:/// URLs for vite (#5169) add batch failure notifications (#5157) PRO-8735 PR take 2 (#5168) ...
haroun
added a commit
that referenced
this pull request
Dec 10, 2025
* main: (26 commits) more (#5207) adds permission.isAdmin (#5192) Skip string choices, disallow type change (#5203) Fix stylelint dependency conflict (#5199) oops old version number in main (#5201) just merging back the changelog (#5198) PRO-8758: soft-redirect and url encoding (#5191) Fix admin UI crashes (#5195) PRO-8756: monorepo workflows (#5179) PRO-8768: relative paths for the good operating systems (#5194) bump express-cache-on-demand to 1.0.4 (#5190) the video is no longer available, use apostrophecms channel video wit… (#5183) add changelog for pro-8751 (#5187) pro 8751 schema update (#5176) Pro 8761 i18n static tests (#5185) Pro 8756 monorepo switch (#5177) release 4.24.0 (#5173) PRO-8743: windows fix 2b: back off on the file:/// URLs for vite (#5169) add batch failure notifications (#5157) PRO-8735 PR take 2 (#5168) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unhandled errors in some cases, that lead to blank editor modals.
Points to possible edge cases.
Note: this is a quick fix of a bigger problem. This should be converted to more defensive code with less state changes and try/catch error handling. Another side effect that needs testing is modals reporting change when there is no change in the state (needs confirmation).
The regression origin: #5176
What are the specific steps to test this change?
No unhandled errors.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: