Use ts::bravo::shared_mutex for host status lock#13367
Open
masaori335 wants to merge 1 commit into
Open
Conversation
HostStatus lookups sit on the parent-selection hot path and are overwhelmingly reads, so replace the ink_rwlock with the reader-biased BRAVO shared_mutex for better read scaling under contention. Readers take ts::bravo::shared_lock (Token-aware); writers use std::scoped_lock.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HostStatus synchronization primitive on the parent-selection hot path, replacing the legacy ink_rwlock with the reader-biased ts::bravo::shared_mutex to improve read-side scaling under contention.
Changes:
- Replace
ink_rwlockwithts::bravo::shared_mutexinHostStatus. - Convert write locking to RAII (currently via
std::scoped_lock) and read locking tots::bravo::shared_lock.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/proxy/HostStatus.cc | Removes manual rwlock init/destroy and converts call sites to BRAVO shared/exclusive RAII locking. |
| include/proxy/HostStatus.h | Switches the lock member type and include to ts::bravo::shared_mutex / tsutil/Bravo.h. |
Comment on lines
+336
to
340
| ts::bravo::shared_lock<ts::bravo::shared_mutex> lock(host_status_rwlock); | ||
|
|
||
| auto it = hosts_statuses.find(std::string(name)); | ||
| lookup = it != hosts_statuses.end(); | ||
| if (lookup) { |
Contributor
Author
There was a problem hiding this comment.
It looks like pre-existing issue. I'll cover this in another PR to clarify scope of changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostStatus lookups sit on the parent-selection hot path and are overwhelmingly reads, so replace the ink_rwlock with the reader-biased BRAVO shared_mutex for better read scaling under contention. Readers take ts::bravo::shared_lock (Token-aware); writers use std::scoped_lock.