Fix set-status crash inside if/endif at remap time

[moonchen]

Operators inside an if/endif block never had set_hook() called on them, so _hook retained its default value of TS_HTTP_READ_RESPONSE_HDR_HOOK. When set-status executed at REMAP_PSEUDO_HOOK time, exec() took the response-hook branch and called TSHttpHdrStatusSet on a request buffer, corrupting the header union and crashing.

Fix the operator to check TSHttpHdrTypeGet() at runtime instead of trusting get_hook(). Removed _hook and get_hook() from operators.

set_hook() becomes is_hook_valid() in Statement and RuleSet to only validate hook compatibility without mutating _hook.

Upgrade the HTTPHdr::status_set/reason_set asserts to release_assert so that writing response fields into a request buffer is caught immediately rather than silently corrupting memory.

Includes an autest that reproduces the crash scenario: set-status 403 inside an if/endif block under REMAP_PSEUDO_HOOK.

[zwoop]

Does this still need to be marked as a Draft ?

[Copilot]

Pull request overview

Fixes a crash in the header_rewrite plugin when set-status is used inside an if/endif block during REMAP_PSEUDO_HOOK execution by avoiding hook-based assumptions and instead checking the actual header type at runtime. This also hardens core HTTP header manipulation by turning response-polarity debug asserts into release asserts to prevent silent memory corruption.

Changes:

• Update set-status execution logic to branch based on TSHttpHdrTypeGet() rather than a stored hook value.
• Replace Statement::set_hook() with a non-mutating Statement::is_hook_valid() for hook compatibility checks during config parsing.
• Add a gold test reproducing the remap-time nested if/endif set-status crash and validating a 403 proxy response.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/gold_tests/pluginTest/header_rewrite/rules/set_status_in_if.conf	Adds minimal header_rewrite rules reproducing nested if/endif set-status at remap time.
tests/gold_tests/pluginTest/header_rewrite/header_rewrite_bundle.replay.yaml	Adds a remap mapping and a replay session asserting set-status yields 403 without crashing.
src/proxy/hdrs/HTTP.cc	Promotes response-polarity asserts for status/reason setters to ink_release_assert.
include/proxy/hdrs/HTTP.h	Promotes response-polarity asserts for HTTPHdr::status_set/reason_set to ink_release_assert.
plugins/header_rewrite/statement.h	Removes stored hook state from Statement; introduces is_hook_valid() API.
plugins/header_rewrite/statement.cc	Implements is_hook_valid() as a pure validation check (no mutation).
plugins/header_rewrite/ruleset.cc	Uses is_hook_valid() when validating operator/condition compatibility with the rule hook.
plugins/header_rewrite/operators.cc	Fixes OperatorSetStatus::exec() to detect response vs request by header type; adjusts redirect debug logging to not reference removed hook state.

[moonchen]

@zwoop ready for review when you have a chance

[zwoop]

Looks good.

[cmcfarlen]

Cherry-picked to 10.2.x