Cleanup: Use enum class#12249
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Converts traditional enums to strongly-typed enum class across headers and documentation, updating member types, function signatures, and references to use scoped enum values.
- Replaces nearly all non-class enums with
enum classvariants (some with explicit underlying types). - Updates fields, parameters, function return types, and bitmask flag operations to use the new enum classes.
- Refreshes documentation and API examples to reference the scoped enum names.
bneradt
approved these changes
May 20, 2025
bneradt
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Thank you for the improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request converts non-class enums to enum classes.
There are still many non-class enums not addressed in this pull request.
However, since the changes have grown quite large, I'm submitting it at this point.