Skip to content

Cleanup: Use enum class#12249

Merged
bneradt merged 87 commits into
apache:masterfrom
hnakamur:use_enum_class
May 21, 2025
Merged

Cleanup: Use enum class#12249
bneradt merged 87 commits into
apache:masterfrom
hnakamur:use_enum_class

Conversation

@hnakamur

Copy link
Copy Markdown
Contributor

This pull request converts non-class enums to enum classes.
There are still many non-class enums not addressed in this pull request.
However, since the changes have grown quite large, I'm submitting it at this point.

hnakamur added 30 commits May 18, 2025 00:43
@bryancall bryancall added this to the 10.2.0 milestone May 19, 2025
@bryancall bryancall requested review from bneradt and Copilot May 19, 2025 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Converts traditional enums to strongly-typed enum class across headers and documentation, updating member types, function signatures, and references to use scoped enum values.

  • Replaces nearly all non-class enums with enum class variants (some with explicit underlying types).
  • Updates fields, parameters, function return types, and bitmask flag operations to use the new enum classes.
  • Refreshes documentation and API examples to reference the scoped enum names.

@bneradt bneradt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants