chore(pyamber): remove dead duplicate TimedBuffer#5981
Conversation
no import of timed_buffer are found or used in Texera
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
============================================
- Coverage 60.26% 60.09% -0.18%
- Complexity 3339 3340 +1
============================================
Files 1133 1131 -2
Lines 43979 43819 -160
Branches 4781 4745 -36
============================================
- Hits 26503 26332 -171
- Misses 16021 16067 +46
+ Partials 1455 1420 -35
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 394 | 0.24 | 24,656/34,926/34,926 us | 🔴 +19.9% / 🔴 +127.2% |
| ⚪ | bs=100 sw=10 sl=64 | 913 | 0.558 | 108,598/135,847/135,847 us | ⚪ within ±5% / 🔴 +27.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,095 | 0.668 | 918,822/946,846/946,846 us | ⚪ within ±5% / 🟢 -9.8% |
Baseline details
Latest main b1c4fd2 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 394 tuples/sec | 417 tuples/sec | 776.68 tuples/sec | -5.5% | -49.3% |
| bs=10 sw=10 sl=64 | MB/s | 0.24 MB/s | 0.254 MB/s | 0.474 MB/s | -5.5% | -49.4% |
| bs=10 sw=10 sl=64 | p50 | 24,656 us | 20,556 us | 12,599 us | +19.9% | +95.7% |
| bs=10 sw=10 sl=64 | p95 | 34,926 us | 41,734 us | 15,370 us | -16.3% | +127.2% |
| bs=10 sw=10 sl=64 | p99 | 34,926 us | 41,734 us | 18,723 us | -16.3% | +86.5% |
| bs=100 sw=10 sl=64 | throughput | 913 tuples/sec | 944 tuples/sec | 994.07 tuples/sec | -3.3% | -8.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.558 MB/s | 0.576 MB/s | 0.607 MB/s | -3.1% | -8.0% |
| bs=100 sw=10 sl=64 | p50 | 108,598 us | 103,994 us | 100,754 us | +4.4% | +7.8% |
| bs=100 sw=10 sl=64 | p95 | 135,847 us | 133,045 us | 106,898 us | +2.1% | +27.1% |
| bs=100 sw=10 sl=64 | p99 | 135,847 us | 133,045 us | 113,210 us | +2.1% | +20.0% |
| bs=1000 sw=10 sl=64 | throughput | 1,095 tuples/sec | 1,123 tuples/sec | 1,027 tuples/sec | -2.5% | +6.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.668 MB/s | 0.685 MB/s | 0.627 MB/s | -2.5% | +6.6% |
| bs=1000 sw=10 sl=64 | p50 | 918,822 us | 890,006 us | 979,814 us | +3.2% | -6.2% |
| bs=1000 sw=10 sl=64 | p95 | 946,846 us | 935,782 us | 1,019,689 us | +1.2% | -7.1% |
| bs=1000 sw=10 sl=64 | p99 | 946,846 us | 935,782 us | 1,049,906 us | +1.2% | -9.8% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,508.08,200,128000,394,0.240,24655.64,34925.69,34925.69
1,100,10,64,20,2189.49,2000,1280000,913,0.558,108598.10,135847.17,135847.17
2,1000,10,64,20,18267.79,20000,12800000,1095,0.668,918821.54,946845.74,946845.74|
/request-review @Yicong-Huang |
What changes were proposed in this PR?
amber/src/main/python/core/util/console_message/timed_buffer.py, a dead, unreferenced near-duplicate of the livecore/util/buffer/timed_buffer.py.TimedBufferuser,console_message_manager.py, already imports thebuffer/version, and the sibling files in theconsole_message/directory (error_message,replace_print,timestamp) remain in use and are untouched.Any related issues, documentation, discussions?
Closes: #5980
How was this PR tested?
grep -rn "console_message.timed_buffer" amber/srcreturns no importers, there is no__init__re-export of the module, and no test references it.cd amber/src/main/python && grep -rn "console_message.timed_buffer\|console_message import timed_buffer" ., expect zero matches outside the deleted file itself.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF