Skip to content

chore(pyamber): remove dead duplicate TimedBuffer#5981

Merged
Yicong-Huang merged 3 commits into
apache:mainfrom
Ma77Ball:chore/remove-dead-timed-buffer
Jul 6, 2026
Merged

chore(pyamber): remove dead duplicate TimedBuffer#5981
Yicong-Huang merged 3 commits into
apache:mainfrom
Ma77Ball:chore/remove-dead-timed-buffer

Conversation

@Ma77Ball

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

  • Deleted amber/src/main/python/core/util/console_message/timed_buffer.py, a dead, unreferenced near-duplicate of the live core/util/buffer/timed_buffer.py.
  • No other files change: the only live TimedBuffer user, console_message_manager.py, already imports the buffer/ version, and the sibling files in the console_message/ directory (error_message, replace_print, timestamp) remain in use and are untouched.

Any related issues, documentation, discussions?

Closes: #5980

How was this PR tested?

  • Pure deletion of unreferenced code, so no test was added or changed. Confirmed dead three ways: grep -rn "console_message.timed_buffer" amber/src returns no importers, there is no __init__ re-export of the module, and no test references it.
  • Reviewer can verify with cd amber/src/main/python && grep -rn "console_message.timed_buffer\|console_message import timed_buffer" ., expect zero matches outside the deleted file itself.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.8 in compliance with ASF

no import of timed_buffer are found or used in Texera
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@codecov-commenter

codecov-commenter commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.09%. Comparing base (b1c4fd2) to head (7577810).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5981      +/-   ##
============================================
- Coverage     60.26%   60.09%   -0.18%     
- Complexity     3339     3340       +1     
============================================
  Files          1133     1131       -2     
  Lines         43979    43819     -160     
  Branches       4781     4745      -36     
============================================
- Hits          26503    26332     -171     
- Misses        16021    16067      +46     
+ Partials       1455     1420      -35     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from 412a76f
agent-service 44.59% <ø> (ø) Carriedforward from 412a76f
amber 65.53% <ø> (+0.01%) ⬆️ Carriedforward from 412a76f
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from 412a76f
config-service 52.30% <ø> (ø) Carriedforward from 412a76f
file-service 62.81% <ø> (-1.17%) ⬇️ Carriedforward from 412a76f
frontend 51.50% <ø> (-0.48%) ⬇️ Carriedforward from 412a76f
notebook-migration-service 78.57% <ø> (ø) Carriedforward from 412a76f
pyamber 91.18% <ø> (ø)
workflow-compiling-service 55.14% <ø> (ø) Carriedforward from 412a76f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline

Compared against main b1c4fd2 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 394 0.24 24,656/34,926/34,926 us 🔴 +19.9% / 🔴 +127.2%
bs=100 sw=10 sl=64 913 0.558 108,598/135,847/135,847 us ⚪ within ±5% / 🔴 +27.1%
bs=1000 sw=10 sl=64 1,095 0.668 918,822/946,846/946,846 us ⚪ within ±5% / 🟢 -9.8%
Baseline details

Latest main b1c4fd2 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 394 tuples/sec 417 tuples/sec 776.68 tuples/sec -5.5% -49.3%
bs=10 sw=10 sl=64 MB/s 0.24 MB/s 0.254 MB/s 0.474 MB/s -5.5% -49.4%
bs=10 sw=10 sl=64 p50 24,656 us 20,556 us 12,599 us +19.9% +95.7%
bs=10 sw=10 sl=64 p95 34,926 us 41,734 us 15,370 us -16.3% +127.2%
bs=10 sw=10 sl=64 p99 34,926 us 41,734 us 18,723 us -16.3% +86.5%
bs=100 sw=10 sl=64 throughput 913 tuples/sec 944 tuples/sec 994.07 tuples/sec -3.3% -8.2%
bs=100 sw=10 sl=64 MB/s 0.558 MB/s 0.576 MB/s 0.607 MB/s -3.1% -8.0%
bs=100 sw=10 sl=64 p50 108,598 us 103,994 us 100,754 us +4.4% +7.8%
bs=100 sw=10 sl=64 p95 135,847 us 133,045 us 106,898 us +2.1% +27.1%
bs=100 sw=10 sl=64 p99 135,847 us 133,045 us 113,210 us +2.1% +20.0%
bs=1000 sw=10 sl=64 throughput 1,095 tuples/sec 1,123 tuples/sec 1,027 tuples/sec -2.5% +6.6%
bs=1000 sw=10 sl=64 MB/s 0.668 MB/s 0.685 MB/s 0.627 MB/s -2.5% +6.6%
bs=1000 sw=10 sl=64 p50 918,822 us 890,006 us 979,814 us +3.2% -6.2%
bs=1000 sw=10 sl=64 p95 946,846 us 935,782 us 1,019,689 us +1.2% -7.1%
bs=1000 sw=10 sl=64 p99 946,846 us 935,782 us 1,049,906 us +1.2% -9.8%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,508.08,200,128000,394,0.240,24655.64,34925.69,34925.69
1,100,10,64,20,2189.49,2000,1280000,913,0.558,108598.10,135847.17,135847.17
2,1000,10,64,20,18267.79,20000,12800000,1095,0.668,918821.54,946845.74,946845.74

@Ma77Ball Ma77Ball changed the title chore(pyamber): remove dead duplicate TimedBuffer (draft) chore(pyamber): remove dead duplicate TimedBuffer Jun 28, 2026
@Ma77Ball Ma77Ball marked this pull request as draft June 28, 2026 19:23
@Ma77Ball Ma77Ball changed the title (draft) chore(pyamber): remove dead duplicate TimedBuffer chore(pyamber): remove dead duplicate TimedBuffer Jun 28, 2026
@Ma77Ball Ma77Ball marked this pull request as ready for review July 1, 2026 19:17
@Ma77Ball

Ma77Ball commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

/request-review @Yicong-Huang

@github-actions github-actions Bot requested a review from Yicong-Huang July 6, 2026 21:52
@Yicong-Huang Yicong-Huang added this pull request to the merge queue Jul 6, 2026
Merged via the queue into apache:main with commit 7494414 Jul 6, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead duplicate TimedBuffer in pyamber

3 participants