fix(test): isolate e2e suites by unique workflow/execution id [release/v1.2 backport]#5903
Merged
Yicong-Huang merged 1 commit intoJun 23, 2026
Conversation
…#5888) - Add `TestUtils.workflowContext(id, settings)` that sets both `workflowId` and `executionId` to `id`, and make the DB fixtures plus `setUp`/`cleanupWorkflowExecutionData` take an `id` (the user email is derived from `id` to avoid the unique-email collision). - Give each materializing e2e suite a distinct id so concurrent suites no longer share an Iceberg result keyspace or DB rows: DataProcessingSpec=1, PauseSpec=2, ReconfigurationSpec=3, ReconfigurationIntegrationSpec=4. - Test-only change, no production code; BatchSizePropagationSpec and CheckpointSpec are untouched because they do not materialize results. Closes: apache#5887 - `sbt "WorkflowExecutionService/Test/compile"` compiles clean on Java 17. - Run the previously-flaky suite against the integration services (Postgres test DB + MinIO/S3 + Iceberg catalog, as in the `build / amber` CI job): `sbt "WorkflowExecutionService/testOnly *DataProcessingSpec"`; expect all DataProcessingSpec tests green with no CommitFailedException flake. - The timing-dependent flake could not be reproduced locally (no MinIO/Iceberg env), so final verification is the `build / amber` CI job staying green across re-runs. Co-authored with Claude Opus 4.8 in compliance with ASF (cherry picked from commit 8803d08)
Contributor
Author
|
/request-review @xuang7 @Yicong-Huang |
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.2 #5903 +/- ##
===============================================
Coverage 51.98% 51.98%
Complexity 2480 2480
===============================================
Files 1065 1065
Lines 41290 41290
Branches 4420 4420
===============================================
Hits 21464 21464
Misses 18565 18565
Partials 1261 1261
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Yicong-Huang
changed the title
Yicong-Huang
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
release/v1.2, applied asgit cherry-pick -x 8803d084c.TestUtils.workflowContext(id, ...)helper (DataProcessingSpec=1, PauseSpec=2, ReconfigurationSpec=3, ReconfigurationIntegrationSpec=4), and the DB fixture rows (user/workflow/version/execution, plus a per-id email) are derived from that id, so concurrent suites no longer collide in the shared Iceberg keyspace.TestUtils.scalaimports only: kept release/v1.2'sorg.apache.texera.amber.config.StorageConfigpath and took the cherry-pick's addedExecutionIdentity/WorkflowIdentity/WorkflowSettingsimports needed by the new helper. The four spec files applied cleanly.runWorkflowAndReadTerminalResults/readMaterializedResultshelpers that exist onmaincame from a separate change not onrelease/v1.2; fix(test): isolate e2e suites by unique workflow/execution id #5888 does not touch them, so they are correctly absent here.Any related issues, documentation, discussions?
Related to #5887
How was this PR tested?
sbt "amber/IntegrationTest/testOnly *ReconfigurationIntegrationSpec", and the unit e2e suites viasbt "amber/testOnly *DataProcessingSpec *PauseSpec *ReconfigurationSpec"; expect all green with no IcebergCommitFailedExceptionkeyspace collisions across concurrently-running suites.sbtcould not load onrelease/v1.2(itsproject/lacksAddMetaInfLicenseFiles, unrelated to this change), so full compile/test is left to CI on this PR.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF