Skip to content

[Migrate] Migrate streampark-flink-sqlclient from Scala to Java - #4462

Merged
wolfboys merged 2 commits into
apache:devfrom
shangeyao:migrate/4448-flink-sqlclient-scala-to-java
Jul 29, 2026
Merged

[Migrate] Migrate streampark-flink-sqlclient from Scala to Java#4462
wolfboys merged 2 commits into
apache:devfrom
shangeyao:migrate/4448-flink-sqlclient-scala-to-java

Conversation

@shangeyao

Copy link
Copy Markdown
Contributor

Summary

Dependency chain

This branch builds on #4447 (shims migration, PR #4461). Merge #4461 first, or review as stacked.

Acceptance (#4448)

  • No .scala under streampark-flink-sqlclient (src/main + src/test)
  • Module builds, tests, and shade package succeed
  • mainClass remains org.apache.streampark.flink.cli.SqlClient

Test plan

  • mvn -pl streampark-flink/streampark-flink-sqlclient -am package -DskipITs
  • SqlClientTest (SET command + dynamic property mode resolution)
  • CI Sonar / Backend (on merge)

Closes #4448

Made with Cursor

@shangeyao shangeyao changed the title [Migrate] #4448 Migrate streampark-flink-sqlclient from Scala to Java [Migrate] Migrate streampark-flink-sqlclient from Scala to Java Jul 27, 2026
@shangeyao
shangeyao force-pushed the migrate/4448-flink-sqlclient-scala-to-java branch from e72fb0c to aa0ad20 Compare July 27, 2026 08:05
…o Java

Convert SqlClient CLI entry to Java while preserving FQCN and submission
behavior, remove enumeratum dependency, and add unit tests for runtime mode
resolution.

Co-authored-by: Cursor <cursoragent@cursor.com>
@shangeyao
shangeyao force-pushed the migrate/4448-flink-sqlclient-scala-to-java branch from aa0ad20 to 5a9c5de Compare July 29, 2026 01:46
Use Arrays.asList for argument copying and rename inner launchers from
main to run to satisfy java:S3012 and java:S3051.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

Copy link
Copy Markdown

@wolfboys
wolfboys merged commit be3229e into apache:dev Jul 29, 2026
38 checks passed
shangeyao added a commit to shangeyao/streampark that referenced this pull request Jul 29, 2026
Rebase onto dev after apache#4462 merge; prepare hello-world test image in CI,
replace Throwable catches with specific exception handling, and document
intentionally empty silent watcher callbacks.

Co-authored-by: Cursor <cursoragent@cursor.com>
wolfboys pushed a commit that referenced this pull request Jul 31, 2026
* [Migrate] #4449 Migrate streampark-flink-packer from Scala to Java

Replace all 34 Scala sources in the packer module with Java equivalents,
preserving public API for console and flink-client callers. Tests migrated
to JUnit 5 with Surefire workspace configuration for Maven resolve tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

* [CI] Fix Sonar reliability issues for #4463

Handle InterruptedException in BuildPipeline.launch and check uberJar.delete()
result in MavenTool.

Co-authored-by: Cursor <cursoragent@cursor.com>

* [CI] Fix DockerClientTest and Sonar reliability issues for #4463

Rebase onto dev after #4462 merge; prepare hello-world test image in CI,
replace Throwable catches with specific exception handling, and document
intentionally empty silent watcher callbacks.

Co-authored-by: Cursor <cursoragent@cursor.com>

* [CI] Fix Scala/Java Map interop after packer migration for #4463

DockerImageBuildResponse.podTemplatePaths() now returns a Java Map; convert
via JavaConverters before iterating in KubernetesNativeClientTrait.

Co-authored-by: Cursor <cursoragent@cursor.com>

* [Build] Use properties for packer dependency versions in #4463

Replace hard-coded jackson-annotations and httpclient versions with
property references aligned to the root POM.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flink] Migrate streampark-flink-sqlclient from Scala to Java

2 participants