feat: Add tracing support for ThreadPoolExecutor.invokeAll/invokeAny (issue apache/skywalking#13945) - #817
Open
cyforkk wants to merge 1 commit into
Open
Conversation
…(issue #13945) Add interceptor to propagate tracing context for batch methods: - ThreadPoolExecutor.invokeAll() (both overloads) - ThreadPoolExecutor.invokeAny() (both overloads) The interceptor captures the active tracing context before the method call and wraps each Callable to restore the context when executed. Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
#816 is on going. If yoi have anything to add, welcome to review and comment there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tracing context propagation for ThreadPoolExecutor batch methods.
Changes
ThreadPoolExecutorInvokeInterceptorto capture and restore tracing contextThreadPoolExecutorInstrumentationto intercept:invokeAll(Collection<? extends Callable<T>> tasks)invokeAll(Collection<? extends Callable<T>> tasks, long timeout, TimeUnit unit)invokeAny(Collection<? extends Callable<T>> tasks)invokeAny(Collection<? extends Callable<T>> tasks, long timeout, TimeUnit unit)skywalking-plugin.defHow it works
The interceptor captures the active tracing context before the method call and wraps
each Callable in the collection to restore the context when executed.
Related
Fixes apache/skywalking#13945
🤖 Generated with Claude Code