feat(plc4j/ab-eth): Enable AB-Ethernet Driver reading#2040
Conversation
Add the possibility of multiple readings.
|
Hehe... That's a relic from the old times in s7... There were several messages exchanged in order to establish the connection, so we simply had the counter start at 10...i guess there's absolutely no reason for this in ab-eth. |
|
hehe... What about the transaction counter reinitialization, the reinitialized value should not be the initial value on the variable declaration? I tested using value 1 on the initialization and it works too. I checked the specification and it does not mention any constraint of the first value. |
|
Feel free to change whatever you need. |
|
Ups ... sorry ... the one button is directly next to the other one :-/ |
…the reinitialization (1) . This way we can avoid a future problem that could happen in the reinitialization.
|
Hi @chrisdutz, I changed the transaction counter initialization value. Although it looks like a lot of modification, if you ignore whitespaces you are going to note that is not because I could remove a for statement. Thanks, |
|
Hi @chrisdutz, I've seen that you are preparing for the next release. That is great! Any chance to accept this PR to be included in the new release? Thanks. |
|
I however guess the release will probably still take a while (if I am to do it, as our new crowd-funding system is currently not really over-flowing with budget and I have stopped doing the housekeeping free of charge: https://opencollective.com/friends-of-toddy/projects/create-release-0130) |
Hi everybody!
In this PR I am enabling the AB-Ethernet Driver reading. Also implemented the missing multiple tags reading.
About the transaction counter reinitialization, should not be set to 10 like the declaration?
@chrisdutz, Do you remeber why 10? Using one Opc Server it starts with 32. But 10 is working perfectly!
transaction counter reinitialize