feat: Pypaimon support compaction task - #6761
Closed
kaori-seasons wants to merge 3 commits into
Closed
Conversation
Author
|
@JingsongLi Do you have any good suggestions? |
|
This pull request has had no activity for 90 days. If you'd like to keep it open, please push a new commit or leave a comment. Thanks for the contribution. |
JingsongLi
reviewed
May 24, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Same concerns as #6770:
- 4755 additions with minimal PR description ("Related to issue-6760").
- This introduces an entire compaction framework in Python (coordinator, executor, manager, strategy, tasks, partition predicates) — this is a major feature that needs design discussion.
- No tests listed in the PR template.
- The relationship to the existing Java-side compaction (which handles most production workloads) is unclear. When would users choose Python compaction over Flink/Spark-based compaction?
- Does this PR have any relationship to #7771 (which adds Ray-based distributed compaction) by TheR1sing3un? If so, these should be coordinated.
Please start with a design proposal on the mailing list. A Python compaction implementation needs to be compatible with the Java-side's file format, manifest handling, and commit protocol — this requires careful design review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related to issue-6760
Tests
API and Format
Documentation