feat(connectors): add Meilisearch sink connector#3497
Open
countradooku wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3497 +/- ##
=============================================
- Coverage 74.70% 45.84% -28.86%
Complexity 937 937
=============================================
Files 1257 1255 -2
Lines 124910 109622 -15288
Branches 100583 85341 -15242
=============================================
- Hits 93312 50256 -43056
- Misses 28595 56661 +28066
+ Partials 3003 2705 -298
🚀 New features to boost your workflow:
|
Contributor
|
overall correct approach - JSON-object document model with generated PK is sound, wait_for_tasks + partial-error accounting is thoughtful. test coverage is present but there is |
Contributor
|
/author |
Contributor
Author
|
/ready |
Contributor
|
/author |
Contributor
Author
|
/ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meilisearch-sdkMotivation
This splits the sink portion out of #3404 so the Meilisearch sink can be reviewed and merged independently from the source connector.
Closes #3495.
Validation
cargo sort --no-format --workspacecargo test -p iggy_connector_meilisearch_sinkcargo clippy -p iggy_connector_meilisearch_sink --all-targets -- -D warningsenv CARGO_BIN_EXE_iggy-server=... CARGO_BIN_EXE_iggy-connectors=... cargo test -p integration --test mod -- connectors::meilisearch::meilisearch_sinkgit diff --check