ci: fix edge-gate over-publish and retry license check#3468
Merged
Conversation
The DockerHub :edge refresh gate treated cargo-rail's `empty` scope mode (no Rust crate impact) the same as `workspace`, refreshing every image on any docs/SDK/node-only push. An esbuild bump under examples/node thus triggered a full publish, whose third-party-license release gate then died on a transient crates.io reset. cargo-rail reports three modes, not two: `crates` (a subset), `empty` (no build/test/bench surface, so zero crates ship new code), and `workspace` (all crates). `empty` must not refresh all images, but it also is not "publish nothing": non-crate build inputs (the embedded web UI, Dockerfiles) are still gated per image via gate.paths. So route `empty` through the existing per-image path gate with an empty crate set; only `workspace` and unparsable modes fall open to all images. A web-only push now refreshes just rust-server and web-ui, not all five. Separately, the license validation shells `cargo about` -> `cargo metadata`, which hits the crates.io index and can reset mid-download past cargo's own net retries. Retry that invocation up to three times with backoff so a flake never reddens the gate.
spetz
approved these changes
Jun 13, 2026
numinnex
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DockerHub :edge refresh gate treated cargo-rail's
emptyscope mode (no Rust crate impact) the same as
workspace,refreshing every image on any docs/SDK/node-only push. An
esbuild bump under examples/node thus triggered a full publish,
whose third-party-license release gate then died on a transient
crates.io reset.
cargo-rail reports three modes, not two:
crates(a subset),empty(no build/test/bench surface, so zero crates ship newcode), and
workspace(all crates).emptymust not refreshall images, but it also is not "publish nothing": non-crate
build inputs (the embedded web UI, Dockerfiles) are still gated
per image via gate.paths. So route
emptythrough the existingper-image path gate with an empty crate set; only
workspaceand unparsable modes fall open to all images. A web-only push
now refreshes just rust-server and web-ui, not all five.
Separately, the license validation shells
cargo about->cargo metadata, which hits the crates.io index and can resetmid-download past cargo's own net retries. Retry that invocation
up to three times with backoff so a flake never reddens the gate.