All: Remove deprecated methods for 1.12.0

[dramaticlly]

Remove all methods, classes, and fields marked with "@deprecated will be removed in 1.12.0" across all modules, since 1.11.0 has been released.

Deleted Classes

• SystemProperties → use SystemConfigs
• PartitionStats → use PartitionStatistics interface / BasePartitionStatistics
• DataReader → use PlannedDataReader
• GenericAppenderFactory → use GenericFileWriterFactory
• BaseFileWriterFactory → use RegistryBasedFileWriterFactory
• S3SignRequest, S3SignResponse, S3SignRequestParser, S3SignResponseParser, S3ObjectMapper → use RemoteSign* equivalents

Notable Non-Mechanical Changes

Beyond deleting deprecated code, the following adjustments were needed. Items marked ⚠️ reviewer attention depart from a strict deprecation removal and warrant a closer look:

1. ⚠️ PositionDelete.set(path, pos, row) and row() — Kept without @Deprecated. The public deprecation notice said position deletes with row data are no longer supported, but internal code (BaseTaskWriter, BasePositionDeltaWriter, RewriteTablePathUtil, Avro) still relies on these methods. Reviewer: confirm the methods are safe to retain as package-internal helpers, or whether a follow-up should narrow visibility / push removal to 1.13.0.

2. BaseScan.io() — Kept as a non-deprecated protected method. Internal subclasses (DataScan, BaseDistributedDataScan) use it; the deprecation targeted external callers only.

3. ⚠️ HadoopFileIO.serializeConfWith() — Kept without @Deprecated because the HadoopConfigurable interface still declares the method. Also inlined the constructor logic since the removed constructor was the delegation target. Reviewer: the cleaner path is to deprecate the interface method (and the ResolvingFileIO / SerializableFileIOWithSize × 3 implementations) for 1.13.0 removal, then drop the SerializationUtil instanceof HadoopConfigurable branch and the iceberg.mr.config.serialization.disabled opt-in — those are the only remaining consumers after Core: Move Hadoop conf serialization into SerializableConfiguration #15583 made SerializableConfiguration itself SerializableSupplier-compatible. Happy to land this as a follow-up.

4. BaseParquetReaders.createStructReader(List, StructType, Integer) — Changed from a concrete method (that delegated to the removed 2-param version) to abstract. Both existing subclasses (InternalReader, GenericParquetReaders) already override it.

5. RewriteTablePathUtil.PositionDeleteReaderWriter.writer() — The 4-arg method was a default delegating to the removed 5-arg version. Made it abstract; updated all implementors (RewriteTablePathSparkAction in v3.5/v4.0/v4.1) to implement the 4-arg signature directly.

6. ⚠️ S3V4RestSignerClient — Removed deprecated property fallback logic from baseSignerUri(), endpoint(), and check(). The legacy properties (s3.signer.uri, s3.signer.endpoint) are no longer supported, and endpoint() now requires RESTCatalogProperties.SIGNER_ENDPOINT (previously defaulted to "v1/aws/s3/sign"). Reviewer: this is a stricter behavior change than a pure removal — please confirm downstream catalog adapters / integration tests are aware they must now supply RESTCatalogProperties.SIGNER_ENDPOINT explicitly.

7. Parquet.java — Removed the NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED branch; without the config, always use NameMapping.empty() (the safe default).

8. MetricsConfig.forPositionDelete(Table) — All callers (FlinkAppenderFactory, RegistryBasedFileWriterFactory) updated to use the no-arg forPositionDelete() since row-level position delete metrics are no longer supported.

9. ⚠️ GenericFileWriterFactory — Re-added writerProperties to the constructor and Builder since it was a public non-deprecated setter used by GenericAppenderHelper and kafka-connect RecordUtils. Reviewer: confirm this re-addition matches the intended public surface (i.e., the field was incidentally lost while removing GenericAppenderFactory and should remain on GenericFileWriterFactory).

[nastra]

this shouldn't be removed. Instead, this should go through a Preconditions.checkArgument check

[dramaticlly]

yeah I think RESTCatalogProperties.SIGNER_ENDPOINT is replaced with RESTCatalogProperties.SIGNER_URI and we can rely on LINE 206 to ensure its existence. Sorry it's a bit messy right now

[dramaticlly]

@nastra do you want to take another look as now CI is green. I leave the PositionDelete.set(path, pos, row) and row() as is given there's nontrivial amount of caller still use the Deprecated method, plan to handle in a follow up PR

[pvary]

⚠️ PositionDelete.set(path, pos, row) and row() — Kept without @deprecated. The public deprecation notice said position deletes with row data are no longer supported, but internal code (BaseTaskWriter, BasePositionDeltaWriter, RewriteTablePathUtil, Avro) still relies on these methods. Reviewer: confirm the methods are safe to retain as package-internal helpers, or whether a follow-up should narrow visibility / push removal to 1.13.0.

We should remove them. Some of the calls are already with null, so that should not be an issue, the others are not something where we can communicate the deprecation with annotation. That is why we added https://iceberg.apache.org/spec/#position-delete-files-with-row-data.

So I suggest that remove the functionality too - Definitely in another PR.

BaseParquetReaders.createStructReader(List, StructType, Integer) — Changed from a concrete method (that delegated to the removed 2-param version) to abstract. Both existing subclasses (InternalReader, GenericParquetReaders) already override it.

This is ok.

RewriteTablePathUtil.PositionDeleteReaderWriter.writer() — The 4-arg method was a default delegating to the removed 5-arg version. Made it abstract; updated all implementors (RewriteTablePathSparkAction in v3.5/v4.0/v4.1) to implement the 4-arg signature directly.

This is ok.

MetricsConfig.forPositionDelete(Table) — All callers (FlinkAppenderFactory, RegistryBasedFileWriterFactory) updated to use the no-arg forPositionDelete() since row-level position delete metrics are no longer supported.

This is ok.

GenericFileWriterFactory — Re-added writerProperties to the constructor and Builder since it was a public non-deprecated setter used by GenericAppenderHelper and kafka-connect RecordUtils. Reviewer: confirm this re-addition matches the intended public surface (i.e., the field was incidentally lost while removing GenericAppenderFactory and should remain on GenericFileWriterFactory).

I don't see this "re-addition" in the PR, but it should be fine, as long as the positionDeleteRowSchema is not added back

[dramaticlly]

Want to callout the potential behavior change due to removal of the SystemConfigs .NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED config (deprecated since 1.5.0), given #9324 suggested that we shall always use NameMapping.empty() as the the safe default for assigning column IDs by position if a file is missing IDs and there is no name mapping.

Before we have

iceberg/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java

Lines 1556 to 1563 in cfebc8e

	NameMapping mapping;
	if (nameMapping != null) {
	mapping = nameMapping;
	} else if (SystemConfigs.NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED.value()) {
	mapping = null;
	} else {
	mapping = NameMapping.empty();
	}

, after this PR the default change from null to NameMapping.empty()

mapping value	Behavior when file has no field IDs
null	unsafe positional ID assignment
NameMapping.empty()	strict resolution against an empty mapping, projected fields read as null / fail

Test migrations off positional fallback

These tests wrote Parquet files via raw AvroParquetWriter / ParquetWriteSupport (no Iceberg field IDs) and read them back without a NameMapping. They had been passing only because the default for unset NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED was true. With the strict default in place, each is migrated to supply withNameMapping(MappingUtil.create(schema))

• ac9ee16a64 TestGenericData.testTwoLevelList, TestParquetEncryptionWithWriteSupport.testTwoLevelList + a new TestGenericData.testReadWithoutFieldIdsOrNameMappingReturnsNullFields that asserts the new strict-default behavior (previously no test covered the NameMapping.empty() path that the PR is shipping).
• 8da506219d TestFlinkParquetReader.testTwoLevelList across v1.20, v2.0, v2.1.
• 8846661ea7 TestSparkParquetReader.testInt96TimestampProducedBySparkIsReadCorrectly across v3.5, v4.0, v4.1.

Production fixes auto-applying the table's schema.name-mapping.default

While migrating the Spark tests we found two real product gaps where Iceberg APIs were not consulting the well-known DEFAULT_NAME_MAPPING table property even though the comparable APIs already did. Both gaps used to be invisible because the same callers relied on the unsafe positional fallback; with that path gone, the gaps surface as test failures. Each commit brings the API into line with the existing pattern in AddFilesProcedure.ensureNameMappingPresent / BaseReader:

• 9ebb273258 SparkTableUtil.importSparkTable now auto-sets schema.name-mapping.default on the target table when not already set, matching the long-standing behavior of AddFilesProcedure and BaseTableCreationSparkAction. Without this, every user who imported a non-Iceberg Parquet table needed to manually configure name mapping to read it back.
• 8846661ea7 GenericReader (used by IcebergGenerics.read(table)) now reads schema.name-mapping.default from the table properties and threads it through ReadBuilder.withNameMapping(...), matching what Spark's BaseReader does. Without this, even tables that do have the property set would still fail to apply it on the generic read path.