feat(scan): [2/N] carry deletion-vector coordinates on FileScanTaskDeleteFile#2868
Open
mbutrovich wants to merge 4 commits into
Open
feat(scan): [2/N] carry deletion-vector coordinates on FileScanTaskDeleteFile#2868mbutrovich wants to merge 4 commits into
mbutrovich wants to merge 4 commits into
Conversation
Add referenced_data_file, content_offset, and content_size_in_bytes to FileScanTaskDeleteFile, populated from the delete file's manifest entry. These locate a deletion-vector blob and scope it to its data file, which the delete loader needs to read and apply V3 deletion vectors. Refs apache#2792.
3 tasks
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
deletion-vector-v1Puffin blobs) #2792.What changes are included in this PR?
Adds
referenced_data_file,content_offset, andcontent_size_in_bytestoFileScanTaskDeleteFile, populated from the delete file's manifest entry (DataFile) inFrom<&DeleteFileContext>.content_offset/content_size_in_byteslocate a deletion-vector blob within its Puffin file, andreferenced_data_filescopes it to the data file it applies to. The delete loader will use these to read and apply V3 deletion vectors (a later PR in this epic).This mirrors Iceberg-Java, where a deletion vector is a
DeleteFile(content=POSITION_DELETES,format=PUFFIN) carrying these fields, attached to a task viaFileScanTask.deletes().No behavior change on its own: the fields default to
Noneand are only populated, nothing reads them yet. This is independent of the codec PR #2866; both are prerequisites for the loader.Are these changes tested?
Unit test in
delete_file_index.rs: builds a deletion-vector-shapedDataFile(Puffin,PositionDeletes, withcontent_offset/content_size_in_bytes/referenced_data_file), converts it to aFileScanTaskDeleteFile, and asserts the three coordinates survive the conversion.This is also exercised end to end against deletion vectors written by Spark / Iceberg-Java in a draft DataFusion Comet PR (apache/datafusion-comet#4887), which reads real V3 merge-on-read tables through this path.