Skip to content

[client] Avoid per-record AutoPartitionStrategy construction in WriterClient.doSend in log tables #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fresh-borzoni merged 3 commits into from
Jul 3, 2026
Merged

[client] Avoid per-record AutoPartitionStrategy construction in WriterClient.doSend in log tables #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b14ca7
perf(write): skip auto-partition work for non-partitioned tables
binary-signal Jun 24, 2026
be9e5c4
address comments
binary-signal Jun 25, 2026
2e4d03e
Address review feedback on #3529
binary-signal Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions fluss-client/src/main/java/org/apache/fluss/client/write/DynamicPartitionCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.fluss.exception.PartitionNotExistException;
import org.apache.fluss.metadata.PhysicalTablePath;
import org.apache.fluss.metadata.ResolvedPartitionSpec;
import org.apache.fluss.metadata.TableInfo;
import org.apache.fluss.metadata.TablePath;
import org.apache.fluss.utils.AutoPartitionStrategy;
import org.apache.fluss.utils.ExceptionUtils;
Expand Down Expand Up @@ -66,9 +67,7 @@ public DynamicPartitionCreator(
}

public void checkAndCreatePartitionAsync(
PhysicalTablePath physicalTablePath,
List<String> partitionKeys,
AutoPartitionStrategy autoPartitionStrategy) {
PhysicalTablePath physicalTablePath, TableInfo tableInfo) {
String partitionName = physicalTablePath.getPartitionName();
if (partitionName == null) {
// no need to check and create partition
Expand All @@ -87,7 +86,11 @@ public void checkAndCreatePartitionAsync(
// if the partition exists, we should skip creating it.
LOG.debug("Partition {} already exists, skipping.", physicalTablePath);
} else {
// Validate early, before touching any state.
// Validate early, before touching any state. The strategy is only resolved here,
// on the partition-creation path, not on the common "already exists" path.
List<String> partitionKeys = tableInfo.getPartitionKeys();
AutoPartitionStrategy autoPartitionStrategy =
tableInfo.getTableConfig().getAutoPartitionStrategy();
ResolvedPartitionSpec resolvedPartitionSpec =
ResolvedPartitionSpec.fromPartitionName(partitionKeys, partitionName);
validateAutoPartitionTime(
Expand Down
8 changes: 4 additions & 4 deletions fluss-client/src/main/java/org/apache/fluss/client/write/WriterClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ private void doSend(WriteRecord record, WriteCallback callback) {

TableInfo tableInfo = record.getTableInfo();
PhysicalTablePath physicalTablePath = record.getPhysicalTablePath();
dynamicPartitionCreator.checkAndCreatePartitionAsync(
physicalTablePath,
tableInfo.getPartitionKeys(),
tableInfo.getTableConfig().getAutoPartitionStrategy());
// Skip the call entirely on non-partitioned tables; there is no partition to create.
if (tableInfo.isPartitioned()) {
dynamicPartitionCreator.checkAndCreatePartitionAsync(physicalTablePath, tableInfo);
}

// maybe create bucket assigner.
Cluster cluster = metadataUpdater.getCluster();
Expand Down
Loading