Skip to content

[dist] Deploy fluss-dist package with start scripts and config files included#184

Merged
wuchong merged 2 commits into
apache:mainfrom
wuchong:deploy-fluss-dist
Dec 17, 2024
Merged

[dist] Deploy fluss-dist package with start scripts and config files included#184
wuchong merged 2 commits into
apache:mainfrom
wuchong:deploy-fluss-dist

Conversation

@wuchong

@wuchong wuchong commented Dec 14, 2024

Copy link
Copy Markdown
Member

Purpose

Package start shell scripts and config files into the fluss-dist jar package, and deploy fluss-dist to maven central when releasing. This allows companies to directly use the source code of shell scripts and config files and package their own enterprise Fluss distribution by extracting the scripts and conf files from the fluss-dist jar.

Tests

API and Format

Documentation

@wuchong wuchong requested a review from luoyuxia December 14, 2024 13:32

@luoyuxia luoyuxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong Thanks for the pr. I left some comments

@@ -51,4 +51,4 @@ logger.netty.level=OFF
logger.jindo_fsStats.name=com.aliyun.jindodata.common.FsStats

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the jindo releated properties since there's no jindo...

Comment thread fluss-dist/pom.xml
<scope>provided</scope>
</dependency>

<dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If remove these dependency in here, fluss-dist wll be build before fluss-lakehouse-paimon, then it'll throw

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single (opt) on project fluss-dist: Failed to create assembly: Error adding file to archive: /Users/luoyuxia/Project/fluss/fluss-dist/../fluss-lakehouse/fluss-lakehouse-paimon/target/fluss-lakehouse-paimon-0.6-SNAPSHOT.jar -> [Help 1]
` ```
while building..

@wuchong

wuchong commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

@luoyuxia thanks, comments addressed.

@luoyuxia luoyuxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wuchong wuchong merged commit c770262 into apache:main Dec 17, 2024
@wuchong wuchong deleted the deploy-fluss-dist branch December 17, 2024 02:32
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
fresh-borzoni pushed a commit to fresh-borzoni/fluss that referenced this pull request Jul 3, 2026
fresh-borzoni pushed a commit that referenced this pull request Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants