[fix] Add FoundationDB chart retention guardrails#503
Open
Al-assad wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FoundationDBClusterresource by default in thedoris-foundationdbchart withhelm.sh/resource-policy: keepStorageClasswithreclaimPolicy=RetainMotivation
FoundationDB stores metadata for storage-compute decoupled Doris deployments. A Doris config-only change, such as updating BE config maps or compute-group settings, should not implicitly tear down the FoundationDB metadata cluster.
This change adds chart-level guardrails to reduce accidental metadata loss when Helm would otherwise delete the
FoundationDBClusterresource during uninstall, upgrade, or rollback workflows.Important behavior
helm.sh/resource-policy: keepprevents Helm from deleting theFoundationDBClusterresource, but the retained resource becomes orphaned from the Helm release. Operators must account for that behavior during uninstall, reinstall, orhelm install --replaceworkflows.This guardrail does not replace deployment-level lifecycle separation. FoundationDB should still be deployed and upgraded independently from Doris config-only changes.
This guardrail also does not control PV reclaim behavior. Production deployments should explicitly configure a
StorageClasswithreclaimPolicy=Retainfor FoundationDB metadata volumes.